-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct detection logic for Edge & Firefox Nightly #6364
Conversation
Correct detection logic for Edge & Firefox Nightly on MacOSX
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Checked Edge variants (from https://www.microsoftedgeinsider.com/en-us/download) on Mac - this PR fixes the detection. and prints correct information when doing |
As part of this PR, should we order the editions Stable => Beta => Dev => Canary, so it goes most stable => least stable? |
Checked Firefox Nightly and Dev on Mac (from https://www.mozilla.org/en-US/firefox/channel/desktop/) - correct detection |
Feel free just to copy changes into @flotwig ‘s pr. I am not precious about it being from this PR |
Woop woop! Job’s a good un. Firefox support looks so good guys, all my work tests passed first time with exception to that that require web security disabled. Will see if I can find a workaround as per chrome, when I get some time. Thanks for all the hard work as usual |
@YOU54F one other thing you can do - skip those tests on firefox selectively https://github.com/cypress-io/cypress-skip-test#imports-with-callback |
Sweet, that looks really nice! For now, I invoke a single smoke test that goes through our entire journey with chromewebsecurity off and with ignore x frame headers extension in a seperate invocation of cypress and all our other tests run with the normal configuration so not an issue for now, but that is good to know 👌 |
Correct detection logic for Edge & Firefox Nightly on MacOSX
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?